Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to click==8.0.4 in pre-commit config #1735

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

mayaCostantini
Copy link
Contributor

Related Issues and Dependencies

Fixes #1734

This introduces a breaking change

  • No

This should yield a new module release

  • No

This Pull Request implements

Revert to an earlier version of click in pre-commit config to avoid error related to _unicodefun import in black.

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2022
@mayaCostantini mayaCostantini changed the title Revert to in pre-commit config Revert to click==8.0.4 in pre-commit config Mar 29, 2022
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯 👍🏻

we should probably write prescriptions for this

@sesheta
Copy link
Member

sesheta commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@sesheta sesheta merged commit ba9ebff into thoth-station:master Mar 29, 2022
@mayaCostantini mayaCostantini deleted the fix-precommit branch March 29, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError from click causes pre-commit to fail
3 participants